Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coveralls to CI #1925

Merged
merged 6 commits into from
Dec 4, 2024
Merged

Add coveralls to CI #1925

merged 6 commits into from
Dec 4, 2024

Conversation

fehiepsi
Copy link
Member

@fehiepsi fehiepsi commented Dec 3, 2024

Fixes #1851

Copy link
Member

@OlaRonning OlaRonning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @fehiepsi!

@fehiepsi fehiepsi merged commit d8bc7f7 into master Dec 4, 2024
8 checks passed
@fehiepsi fehiepsi deleted the codecov branch December 4, 2024 15:53
@tillahoffmann
Copy link
Contributor

This is great! Although it looks like the coverage only includes function/class declarations but not execution? Maybe I'm reading the output incorrectly. Cf. https://coveralls.io/jobs/156920399/source_files/36850092820

@fehiepsi
Copy link
Member Author

fehiepsi commented Dec 5, 2024

@tillahoffmann hope it is fixed in #1927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CodeCov
3 participants