Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Versioneer #164

Merged
merged 2 commits into from
Jan 13, 2023
Merged

Update Versioneer #164

merged 2 commits into from
Jan 13, 2023

Conversation

github-actions[bot]
Copy link
Contributor

Automatic update of Versioneer by the versioneer.yml workflow.

@jGaboardi
Copy link
Member

xref #160

@jGaboardi jGaboardi self-assigned this Jan 13, 2023
@martinfleis
Copy link
Member

is CI checking this or shall I do it locally?

@jGaboardi
Copy link
Member

is CI checking this or shall I do it locally?

CI is checking. Just waiting for tests to pass.

@jGaboardi
Copy link
Member

And now they have!

@jGaboardi jGaboardi merged commit 215317b into main Jan 13, 2023
@jGaboardi jGaboardi deleted the update-versioneer branch January 13, 2023 21:34
@martinfleis
Copy link
Member

CI is checking. Just waiting for tests to pass.

I meant if it is checking that the __version__ works, not if it runs.

@jGaboardi
Copy link
Member

CI is checking. Just waiting for tests to pass.

I meant if it is checking that the __version__ works, not if it runs.

Ah, not sure about that exactly, but seems to have worked when implemented in spaghetti & spopt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jGaboardi jGaboardi jGaboardi approved these changes

Assignees

@jGaboardi jGaboardi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jGaboardi @martinfleis