Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint code base with ruff #195

Merged
merged 7 commits into from
Sep 6, 2023
Merged

lint code base with ruff #195

merged 7 commits into from
Sep 6, 2023

Conversation

jGaboardi
Copy link
Member

This PR resolves #185

@jGaboardi jGaboardi self-assigned this Sep 6, 2023
@jGaboardi jGaboardi changed the title Ruff lint lint code base with ruff Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #195 (aa2f44c) into main (7223042) will decrease coverage by 0.1%.
The diff coverage is 87.1%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #195     +/-   ##
=======================================
- Coverage   88.8%   88.7%   -0.1%     
=======================================
  Files          8       8             
  Lines       1112    1107      -5     
=======================================
- Hits         987     982      -5     
  Misses       125     125             
Files Changed Coverage Δ
mapclassify/greedy.py 92.1% <40.0%> (ø)
mapclassify/classifiers.py 88.1% <96.0%> (-0.1%) ⬇️
mapclassify/pooling.py 84.2% <100.0%> (ø)

mapclassify/classifiers.py Outdated Show resolved Hide resolved
mapclassify/classifiers.py Outdated Show resolved Hide resolved
mapclassify/classifiers.py Outdated Show resolved Hide resolved
mapclassify/classifiers.py Show resolved Hide resolved
mapclassify/classifiers.py Show resolved Hide resolved
jGaboardi and others added 3 commits September 6, 2023 15:34
Co-authored-by: Martin Fleischmann <[email protected]>
Co-authored-by: Martin Fleischmann <[email protected]>
Co-authored-by: Martin Fleischmann <[email protected]>
@jGaboardi
Copy link
Member Author

Also, the release action is being triggered for these CI runs. Need to get that under control.

@jGaboardi
Copy link
Member Author

Also, the release action is being triggered for these CI runs. Need to get that under control.

There was a syntax error in .github/workflows/release.yml resulting a failed evaluation; it was not actually being triggered.

@martinfleis Is this ready to merge following this next passing CI?

Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Thanks!

@jGaboardi jGaboardi merged commit 412fabc into pysal:main Sep 6, 2023
14 checks passed
@jGaboardi jGaboardi deleted the ruff_lint branch September 6, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix linting failures
2 participants