feat(cli): add close publisher caps #546
Merged
+31
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
guibescos
reviewed
Dec 30, 2024
| RpcProgramAccountsConfig { | ||
| filters: Some(vec
There was a problem hiding this comment.
you should filter on data here
guibescos
reviewed
Dec 30, 2024
guibescos
reviewed
Dec 30, 2024
staking/cli/src/main.rs
Outdated
| @@ -97,5 +99,14 @@ fn main() { | |||
| Action::SaveStakeAccountsSnapshot {} => { | |||
| save_stake_accounts_snapshot(&rpc_client); | |||
| } | |||
| Action::ClaimRewards { | |||
| min_staked, | |||
| min_reward, | |||
There was a problem hiding this comment.
I don't like having two parameters here. I feel like we should be disciplined and:
- either claim all rewards for accounts with min_staked
- or claim all rewards s.t. reward > min_reward
guibescos
reviewed
Dec 30, 2024
staking/cli/src/cli.rs
Outdated
| ClaimRewards { | ||
| #[clap(long, help = "Minimum staked tokens")] | ||
| min_staked: u64, | ||
| #[clap(long, help = "Minimum reward tokens per publisher")] |
There was a problem hiding this comment.
add a comment saying this is with full decimals?
guibescos
reviewed
Dec 30, 2024
staking/cli/src/instructions.rs
Outdated
| .filter_map(|positions| { | ||
| let acc = positions.to_dynamic_position_array(); | ||
| let valid = acc | ||
| .get_target_exposure(&Target::IntegrityPool, current_epoch) |
There was a problem hiding this comment.
Not sure about using get_target_exposure here. get_target_exposure ignores UNLOCKED positions but these can have unclaimed rewards
keyvankhademi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.