fix: don't submit order with negative output (#300)

* fix: don't submit order with negative output * fix: don't submit order with negative output * fix: mention anchor explicitly
pyth-network · Dec 17, 2024 · 91a00a9 · 91a00a9
1 parent 0062806
commit 91a00a9
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 7 deletions.
diff --git a/scripts/limonade/package.json b/scripts/limonade/package.json
@@ -1,6 +1,6 @@
 {
   "name": "limonade",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "description": "This script is used to submit new opportunities fetched from the limo program to the express relay.",
   "main": "index.js",
   "scripts": {

diff --git a/scripts/limonade/src/index.ts b/scripts/limonade/src/index.ts
@@ -47,7 +47,6 @@ const argv = yargs(hideBin(process.argv))
     description:
       "API key to authenticate with the express relay server for publishing opportunities.",
     type: "string",
-    demandOption: true,
   })
   .option("number-of-concurrent-submissions", {
     description: "Number of concurrent submissions to the express relay server",
@@ -141,7 +140,11 @@ async function run() {
         e.message.includes("Same opportunity is submitted recently")
       )
     ) {
-      console.error("Failed to submit opportunity", e);
+      console.error(
+        "Failed to submit opportunity",
+        e,
+        e.message ? e.message : ""
+      );
     }
   };
   const setHermesConnectionTimeout = () => {
@@ -187,7 +190,9 @@ async function run() {
           try {
             await client.submitOpportunity(payload);
           } catch (e) {
-            handleSubmitError(e);
+            if (e instanceof ClientError && e.message.includes("422")) {
+              console.log(payload);
+            }
           }
         })
       );

diff --git a/sdk/js/package.json b/sdk/js/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@pythnetwork/express-relay-js",
-  "version": "0.16.0",
+  "version": "0.16.1",
   "description": "Utilities for interacting with the express relay protocol",
   "homepage": "https://github.com/pyth-network/per/tree/main/sdk/js",
   "author": "Douro Labs",

diff --git a/sdk/js/src/index.ts b/sdk/js/src/index.ts
@@ -379,10 +379,12 @@ export class Client {
         encoded_order,
         Order.discriminator.length
       );
-      const remainingOutputAmount =
+      const remainingOutputAmount = anchor.BN.max(
         opportunity.order.state.expectedOutputAmount.sub(
           opportunity.order.state.filledOutputAmount
-        );
+        ),
+        new anchor.BN(0)
+      );
       body = {
         chain_id: opportunity.chainId,
         version: "v1" as const,