beacon interface #10
Closed
beacon interface #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anihamde
commented
Jan 17, 2024
anihamde
commented
- minor refactoring
- start websocket hermes prices
- readme for larger Beacon service
- clean up templates for protocols and searchers
- lingering forgotten commit
- add readmes
- some renamings
- cli, ws, doc
m30m
reviewed
Jan 17, 2024
| @@ -30,15 +30,10 @@ def get_vault_abi(): | |||
| return data['abi'] | |||
There was a problem hiding this comment.
does the address in this function make sense?
| print(f"Response, post to beacon: {resp.text}") | ||
| else: | ||
| print(liquidatable) | ||
| await asyncio.sleep(2) |
There was a problem hiding this comment.
I'm not sure if these sleeps are necessary. We have a bunch of network requests in the middle, so each loop naturally takes some hundreds of milliseconds.
added 10 commits
January 18, 2024 00:01
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.