Vault simulator #11
Merged
Vault simulator #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actual pyth contract
vault monitor needs to include value and WETH if necessary searcher uses the new endpoint for bidding
ali-bahjati
reviewed
Feb 2, 2024
There was a problem hiding this comment.
Nice. I left some inline comments (mostly minor) about the code however I am not so familiar with the business logic to approve it.
A couple of notes about build instructions that might be nice to add to readmes or fix:
The auction server only build with stable rust, so perhaps add it to rust-toolschains.toml. Also it needs the ABI's to be present which means we should build it using forge. An ideal way is adding a build.rs build script for the auction server but for now a readme would suffice.
On the forge side, --via-ir is necessary to be able to get around stack too deep issue.
jayantk
reviewed
Feb 2, 2024
Converting ContractError to RestErrors remain in api but logical error handling moved inside the auction module
jayantk
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.