Websocket support #18
Conversation
| store | ||
| .ws | ||
| .update_tx | ||
| .send(NewOpportunity(opportunity.clone().into())) |
There was a problem hiding this comment.
instead of cloning multiple times, maybe you could push opportunity into opportunities_existing, and then call
store.ws.update_tx.send(NewOpportunity(opportunities_existing.last().into()))
There was a problem hiding this comment.
You also don't need to call opportunity.into() below, you could instead just create a new OpportunityParamsWithMetadata object and fill in.
There was a problem hiding this comment.
For the first comment, we technically need opportunity in both places and both structs need to own them in the end so we need to clone.
I didn't understand the second comment, we implement the Into trait so we don't have to do this here.
| let mut exit_check_interval = tokio::time::interval(EXIT_CHECK_INTERVAL); | ||
|
|
||
| // this should be replaced by a subscription to the chain and trigger on new blocks | ||
| let mut submission_interval = tokio::time::interval(Duration::from_secs(5)); |
There was a problem hiding this comment.
the frequency here should depend on the chain_id, probably set in the config
There was a problem hiding this comment.
agreed but out of scope for this PR, will do it separately
| cloned_bids.sort_by(|a, b| b.bid.cmp(&a.bid)); | ||
| tokio::select! { | ||
| _ = submission_interval.tick() => { | ||
| for (chain_id, chain_store) in &store.chains { |
There was a problem hiding this comment.
and relatedly have run_submission_loop take chain_id as an argument and run distinct loops for different chain_ids
auction-server/src/api.rs
Outdated
|
|
||
| let submission_loop = tokio::spawn(run_submission_loop(store.clone())); |
There was a problem hiding this comment.
nit: since these are in different places I think it might be more natural to move this function entirely to main.rs
| @@ -127,22 +139,30 @@ pub async fn post_opportunity( | |||
| } | |||
There was a problem hiding this comment.
The clone in iteration above seems a bit off. I don't know whether it's unnecessary but if you use a map then try_insert can give you this shorter. I see some searchs with the order id.s too.
| @@ -25,3 +25,4 @@ utoipa-swagger-ui = { version = "3.1.4", features = ["axum"] } | |||
| serde_yaml = "0.9.25" | |||
| ethers = "2.0.10" | |||
| axum-macros = "0.4.0" | |||
| dashmap = { version = "5.4.0" } | |||
There was a problem hiding this comment.
Bump the auction-server version as well?
No description provided.