Fix svm slow conclusion #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m30m
reviewed
Dec 14, 2024
| } | ||
|
|
||
| /// This one concludes an auction by getting the auction transaction status from the chain. | ||
| #[tracing::instrument(skip_all, fields(auction_id, tx_hash, bid_ids))] |
There was a problem hiding this comment.
I suggest removing this instrumentation.
tx_hash is a bit misleading now since auction can have multiple transactions.
The rest is traced inside the conclude_auction_with_statuses call.
There was a problem hiding this comment.
I removed the fields, but kept the instument itself.
m30m
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix the svm slow conslusion issue
Sometimes the websocket hears about confirmation before the RPC client. In the previous version the conclude auction was dependent on RPC client also seeing the confirmation transaction. Now in the conclusion log listener worker, the code only use the log to conclude the auction.