Undercollat vault creation #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anihamde
commented
Mar 20, 2024
anihamde
commented
- adapt TokenVault to enable undercollateralized vault creation
- adapt vault simulator to create undercollateralized vaults
- fix various bugs in the deploy scripts and vault-simulator
- add a bit of documentation around installing reqs
m30m
approved these changes
Mar 20, 2024
per_multicall/README.md
Outdated
| @@ -23,6 +23,14 @@ This allows users to participate in liquidations without needing to set up their | |||
|
|
|||
| Tests can be found in `test/`. These tests include checks that the protocol functions work, as well as checks around permissioning, bid conditions, and appropriate failing of components of the express relay bundle (without failing the whole bundle). | |||
|
|
|||
| To install necessary requirements, you should first run | |||
There was a problem hiding this comment.
Isn't this a duplicate? We have these a few lines above.
per_multicall/script/Vault.s.sol
Outdated
| return (expressRelay, opportunityAdapter, mockPyth, vault, weth); | ||
| } | ||
|
|
||
| function mintTokens(address token, address to, uint256 amount) public { |
There was a problem hiding this comment.
I don't understand why we need this. We can just use the cast commands we have in the docs to mint right?
per_multicall/script/Vault.s.sol
Outdated
| @@ -428,10 +455,12 @@ contract VaultScript is Script { | |||
| getNextPublishTime(idToken2Latest), | |||
| 0 | |||
| ); | |||
| console.log("222"); | |||
per_multicall/script/Vault.s.sol
Outdated
|
|
||
| bytes[] memory updateData = new bytes[](2); | ||
| updateData[0] = token1UpdateData; | ||
| updateData[1] = token2UpdateData; | ||
| console.log("333"); |
vault-simulator/src/simulator.rs
Outdated
| let allow_undercollateralized: bool = contract.get_allow_undercollateralized().call().await?; | ||
| if allow_undercollateralized { | ||
| collat_factor = (min_health_numerator + min_health_permissionless_numerator) / 2; | ||
| // Less than 110% to create the vault undercollateralized |
There was a problem hiding this comment.
you can be more specific here that this is between the min_health_ratio and min_health_permissionless_ratio
Also if the autoformatter automaically put this comment in the next line, you can put in the previous line. The comment usually precedes the logic.
vault-simulator/src/simulator.rs
Outdated
| collat_factor = min_health_numerator * 10_001 / 10_000; // Slightly more than 110% to make sure the vault is created | ||
| } | ||
|
|
||
| let amount_collateral: U256 = collateral_value_usd * precision * collat_factor |
There was a problem hiding this comment.
I think it's a bit more readable if you divide collat_factor by min_health_denominator before this line so this line looks similar to the debt line with the only different being this factor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.