Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support pythtest-conformance and pythtest-crosschain #50

Merged
merged 4 commits into from
Jan 4, 2024
Merged

Conversation

cctdaniel
Copy link
Contributor

No description provided.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use hardcoded mapping values instead of DNS TXT record since these values dont change that often anyway

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just curious, who is using these dns values?

Copy link
Contributor Author

@cctdaniel cctdaniel Jan 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually dont know who updates these values, maybe @thmzlt has an idea?

Copy link

@m30m m30m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the comments before merge

pythclient/utils.py Outdated Show resolved Hide resolved
pythclient/utils.py Show resolved Hide resolved
pythclient/utils.py Outdated Show resolved Hide resolved
pythclient/utils.py Outdated Show resolved Hide resolved
@cctdaniel cctdaniel merged commit fdc3432 into main Jan 4, 2024
1 check passed
@cctdaniel cctdaniel deleted the pythtest branch January 4, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants