-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(target_chains/ethereum): add arbirum stylus sdk #2041
base: main
Are you sure you want to change the base?
Conversation
v1.9.3
@Ifechukwudaniel is attempting to deploy a commit to the Pyth Network Team on Vercel. A member of the Team first needs to authorize it. |
This is an early draft of the Pyth stylus SDK. Using external calls. I am working on the examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay with the review! Thank you for the improvements you've made. I agree that sol_interface!
unfortunately turns out to not be usable with IPyth
. I've added a few comments mentioning my remaining concerns. Also, could you please reopen this PR and close the new one (#2202)? I think it's better to keep all relevant discussions in one place.
target_chains/ethereum/sdk/stylus/examples/function-calls/src/lib.rs
Outdated
Show resolved
Hide resolved
target_chains/ethereum/sdk/stylus/pyth-solidity/.github/workflows/test.yml
Outdated
Show resolved
Hide resolved
I am on it thank you for the review |
So I'm am done with git stuff |
#2041 (comment) Do you suggest I just get rid of that function example |
All done |
@Riateche all done |
all done |
I’m currently working on the early draft of the Stylus SDK, focusing on documentation, writing examples, and conducting end-to-end testing for the SDK