Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(target_chains/ethereum): add arbirum stylus sdk #2041

Open
wants to merge 183 commits into
base: main
Choose a base branch
from

Conversation

Ifechukwudaniel
Copy link

I’m currently working on the early draft of the Stylus SDK, focusing on documentation, writing examples, and conducting end-to-end testing for the SDK

Copy link

vercel bot commented Oct 14, 2024

@Ifechukwudaniel is attempting to deploy a commit to the Pyth Network Team on Vercel.

A member of the Team first needs to authorize it.

@Ifechukwudaniel
Copy link
Author

Ifechukwudaniel commented Oct 14, 2024

This is an early draft of the Pyth stylus SDK. Using external calls. I am working on the examples

Copy link
Contributor

@Riateche Riateche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay with the review! Thank you for the improvements you've made. I agree that sol_interface! unfortunately turns out to not be usable with IPyth. I've added a few comments mentioning my remaining concerns. Also, could you please reopen this PR and close the new one (#2202)? I think it's better to keep all relevant discussions in one place.

@Ifechukwudaniel
Copy link
Author

I am on it thank you for the review

@Ifechukwudaniel
Copy link
Author

Ifechukwudaniel commented Dec 20, 2024

So I'm am done with git stuff

@Ifechukwudaniel
Copy link
Author

Ifechukwudaniel commented Dec 20, 2024

#2041 (comment) Do you suggest I just get rid of that function example

@Ifechukwudaniel
Copy link
Author

@Riateche

@Ifechukwudaniel Ifechukwudaniel marked this pull request as ready for review December 21, 2024 21:59
@Ifechukwudaniel
Copy link
Author

All done

@Ifechukwudaniel
Copy link
Author

@Riateche all done

@Ifechukwudaniel
Copy link
Author

all done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants