fix: manual encode array params for hermes #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ali-bahjati
approved these changes
Feb 8, 2024
Reisen
force-pushed
the
push-xqoxukwvukxq
branch
from
09d090d to
e54e791
Compare
Reisen
force-pushed
the
push-xqoxukwvukxq
branch
from
e54e791 to
480459f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTP library in hermes expects array parameters passed in URLs to be encoded with
ids[]=, but the aiohttp library used here does not support encoding this way. This PR updates the call to hand-serialize the URL parameters to match hermes expectations.