Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PublisherStalledCheck #68

Merged
merged 3 commits into from
May 17, 2024
Merged

feat: add PublisherStalledCheck #68

merged 3 commits into from
May 17, 2024

Conversation

cctdaniel
Copy link
Contributor

No description provided.

Copy link
Contributor

@ali-bahjati ali-bahjati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nicely done!

My only worry is that the fact that we are storing prices as float causes problems but let's actually see. We can configure this stall_time_limit per feed too (and let's tell people how to do it).

@cctdaniel cctdaniel merged commit 19c5063 into main May 17, 2024
3 checks passed
@cctdaniel cctdaniel deleted the publisher-stalled-check branch May 17, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants