Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of #19 / #20 we can customize the way expression tuples are evaluated by subclassing
ExpressionTuple
. We would also like to get an instance of these subclasses when etuplizing the corresponding evaluated operators. To do so and keep a consistent API in this PR we allow the functionetuple
to dispatch, and choose which registered version to use withinetuplize
.Since this work was motivated by aesara-devs/aesara#1036, here is an example of how this works in practice:
We cannot avoid dispatching
etuple
if we want to be able to unifyetuple(at.normal.random, ...)
with the result ofetuplize(at.normal.random(x, y))
. We could avoid (the imho awkward)etuplize_fn
by allowing to dispatchetuplize_step
instead (why dispatchetuplize
by the way?).