fix: check_and_call_extract_file uses the first matching method and options, instead of the first matching method and last matching options #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
requested changes
Aug 22, 2024
|
I would love to, but it's very hard to figure out where/how to test this. Basically, I'd need some scaffolding to be able to provide a configuration file, source files and a custom extractor and test whether the output is as expected. |
akx
force-pushed
the
jpmckinney-patch-1
branch
from
62f4fd8 to
b501949
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1121 +/- ##
==========================================
+ Coverage 91.28% 91.45% +0.17%
==========================================
Files 27 27
Lines 4624 4625 +1
==========================================
+ Hits 4221 4230 +9
+ Misses 403 395 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
akx
approved these changes
Dec 9, 2024
…ptions, instead of the first matching method and last matching options
akx
force-pushed
the
jpmckinney-patch-1
branch
from
b501949 to
4856358
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, if I want to use a different method for one file AND use options, I can't do, for example:
The current code will match
path/file.pytomyextractor, but it'll use the empty options frompython...