-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved JavaScript extraction #332
Conversation
Current coverage is
|
And remove unittest boilerplate while at it
This looks fantastic. Thanks for adding further support! |
Any progress on this? I am in need of dotted names as keywords. Thanks. |
@catmeme If you feel like it, could you give the PR a quick code review pass? |
LGTM. |
Merging. (@RauliL is a colleague who I recruited to do CR.) |
@akx, any chance you could update the pip package? We're ready to try out the new JSX extraction! |
@akx Yeah, we are waiting for this too :) |
@akx thanks for this great package. Unfortunately seems like the jsx support is not complete, it doesn't work on something like this:
is it the same for you or am I missing a config? |
@akx nevermind, I downloaded latest dev version (2.4.0-dev) and it's fixed. |
This PR improves the JavaScript message extraction system, adding support for
com.corporate.i18n.gettext
) (Keywords containing dots never match in JS #148)<tag>
s (to avoid misparses) (React Support #280)It's a refactor and superset of the previous JavaScript PRs, so:
Closes #298
Closes #310