-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved javascript template string expression extracting #792
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,7 @@ | |
:license: BSD, see LICENSE for more details. | ||
""" | ||
|
||
import io | ||
import os | ||
from os.path import relpath | ||
import sys | ||
|
@@ -521,8 +522,10 @@ def extract_javascript(fileobj, keywords, comment_tags, options): | |
:param options: a dictionary of additional options (optional) | ||
Supported options are: | ||
* `jsx` -- set to false to disable JSX/E4X support. | ||
* `template_string` -- set to false to disable ES6 | ||
template string support. | ||
* `template_string` -- if `True`, supports gettext(`key`) | ||
* `parse_template_string` -- if `True` will parse the | ||
contents of javascript | ||
template strings. | ||
""" | ||
from babel.messages.jslexer import Token, tokenize, unquote_string | ||
funcname = message_lineno = None | ||
|
@@ -551,7 +554,11 @@ def extract_javascript(fileobj, keywords, comment_tags, options): | |
call_stack = 0 | ||
token = Token('operator', ')', token.lineno) | ||
|
||
if token.type == 'operator' and token.value == '(': | ||
if options.get('parse_template_string') and not funcname and token.type == 'template_string': | ||
for item in parse_template_string(token.value, fileobj, keywords, comment_tags, options): | ||
yield item | ||
|
||
elif token.type == 'operator' and token.value == '(': | ||
if funcname: | ||
message_lineno = token.lineno | ||
call_stack += 1 | ||
|
@@ -643,3 +650,43 @@ def extract_javascript(fileobj, keywords, comment_tags, options): | |
funcname = token.value | ||
|
||
last_token = token | ||
|
||
|
||
def parse_template_string(template_string, fileobj, keywords, comment_tags, options): | ||
|
||
prev_character = None | ||
level = 0 | ||
inside_str = False | ||
expression_contents = '' | ||
|
||
for character in template_string[1:-1]: | ||
|
||
if not inside_str and character in ('"', "'", '`'): | ||
inside_str = character | ||
elif inside_str == character and prev_character != r'\\': | ||
inside_str = False | ||
|
||
if level: | ||
expression_contents += character | ||
|
||
if not inside_str: | ||
|
||
if character == '{' and prev_character == '$': | ||
level += 1 | ||
|
||
elif level and character == '}': | ||
|
||
level -= 1 | ||
|
||
if level == 0 and expression_contents: | ||
|
||
expression_contents = expression_contents[0:-1] | ||
|
||
fake_file_obj = io.BytesIO(expression_contents.encode()) | ||
|
||
for item in extract_javascript(fake_file_obj, keywords, comment_tags, options): | ||
yield item | ||
|
||
expression_contents = '' | ||
|
||
prev_character = character | ||
Comment on lines
+655
to
+692
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you remove the empty lines within the blocks, so the spacing of this code (which is quite airy 😄 ) matches the rest of the codebase? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done in #939. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this interact with e.g. line numbering?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line numbering has been fixed in #939. There is now also a test for that.