Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dead CJ Banner Link #1111

Merged
merged 2 commits into from
Oct 8, 2023
Merged

Fix Dead CJ Banner Link #1111

merged 2 commits into from
Oct 8, 2023

Conversation

HassanAbouelela
Copy link
Member

Possibly we'd want to use banner2 instead?

@HassanAbouelela HassanAbouelela added type: bug Something isn't working area: frontend Related to site content and user interaction priority: 2 - normal Normal Priority labels Sep 19, 2023
@netlify
Copy link

netlify bot commented Sep 19, 2023 •
edited
Loading

✅ Deploy Preview for pydis-static ready!

Name Link
🔨 Latest commit 3fcc2a7
🔍 Latest deploy log https://app.netlify.com/sites/pydis-static/deploys/6522c7ec54e339000868b1d4
😎 Deploy Preview https://deploy-preview-1111--pydis-static.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Sep 19, 2023 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same when pulling 3fcc2a7 on fix-CJ-mobile-banner into 3532cd9 on main.

@jchristgit jchristgit requested a review from kosayoda October 8, 2023 13:17
kosayoda
kosayoda approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@kosayoda kosayoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can switch it to banner2 in the future if needed, no harm going with this fix now.

@kosayoda kosayoda enabled auto-merge October 8, 2023 15:17
@kosayoda kosayoda merged commit 829a786 into main Oct 8, 2023
9 checks passed
@kosayoda kosayoda deleted the fix-CJ-mobile-banner branch October 8, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kosayoda kosayoda kosayoda approved these changes

@jchristgit jchristgit jchristgit approved these changes

@janine9vn janine9vn Awaiting requested review from janine9vn

Assignees

@janine9vn janine9vn

Labels
area: frontend Related to site content and user interaction priority: 2 - normal Normal Priority type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@HassanAbouelela @coveralls @jchristgit @kosayoda @janine9vn