Use kebab-case for keys of valid_filters in resources
#1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hedyhli
added
type: bug
✅ Deploy Preview for pydis-static ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The YAML side uses snake case, whereas the HTML template and JavaScript use kebab case. This difference affects only
Payment tiersright now.Currently if the page has a payment tier filter active, reloading the page would lose the filter. A simple fix would be to use kebab case in
valid_filterswhich will be used in JavaScript.Demo:
https://deploy-preview-1373--pydis-static.netlify.app/resources/?payment-tiers=free&difficulty=beginner
https://www.pythondiscord.com/resources/?payment-tiers=free&difficulty=beginner