-
-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix linkedin userdetails backend #915
base: master
Are you sure you want to change the base?
fix linkedin userdetails backend #915
Conversation
for more information, see https://pre-commit.ci
|
i've tested the changes. i think there's no need for projection param in USER_DETAILS_URL variable. also, here's the official doc url for new scopes |
Thanks for verifying the fix, we still need test suite to pass to be able to merge this. |
yup! if you need anykind of help let me know! |
I have no clue if @MohamedAhmed412000 is interested in pushing this forward, if not, adjusting testsuite is the way to get this merged. |
I will adjust the tests inshallah |
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers
why we should accept this pull request. If it fixes a bug or resolves a feature
request, be sure to link to that issue.
Types of changes
Please check the type of change your PR introduces:
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.
Other information
Any other information that is important to this PR such as screenshots of how
the component looks before and after the change.