Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-122237: Fix REPL wrong auto-indentation with comments #122238

Closed
wants to merge 1 commit into from

Conversation

HarryLHW
Copy link
Contributor

@HarryLHW HarryLHW commented Jul 24, 2024

@HarryLHW
Copy link
Contributor Author

At this point, it will never auto-indent if there is only a comment without other code in the last line. This will produce the following situation, and I am trying to fix that if possible.
image

@JeffersGlass
Copy link
Contributor

At this point, it will never auto-indent if there is only a comment without other code in the last line. This will produce the following situation, and I am trying to fix that if possible.

For what it’s worth, I’m not sure I would consider this a bug. Presumably, the user had to un-indent the comment line deliberately, so I would expect the following line to also be un-indented, if that makes sense.

Are there other situations where this behavior leads to incorrect indentation?

@ambv
Copy link
Contributor

ambv commented Oct 23, 2024

This is fixed already.

@ambv ambv closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants