-
-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-115999: Enable specialization of CALL
instructions in free-threaded builds
#127123
Open
mpage
wants to merge
24
commits into
python:main
Choose a base branch
from
mpage:gh-115999-tlbc-call
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Nov 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6d9b6a2 - Browse repository at this point
Copy the full SHA 6d9b6a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30e25d2 - Browse repository at this point
Copy the full SHA 30e25d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92160de - Browse repository at this point
Copy the full SHA 92160deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4754921 - Browse repository at this point
Copy the full SHA 4754921View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a20bb0 - Browse repository at this point
Copy the full SHA 6a20bb0View commit details -
Enable almost all specializations of CALL
_CALL_ALLOC_AND_ENTER_INIT will be addressed in a separate PR
Configuration menu - View commit details
-
Copy full SHA for ea7206d - Browse repository at this point
Copy the full SHA ea7206dView commit details -
Configuration menu - View commit details
-
Copy full SHA for d5375f1 - Browse repository at this point
Copy the full SHA d5375f1View commit details -
Fix implementation of CALL_LIST_APPEND in free-threaded builds
This needs to acquire a critical section on the list.
Configuration menu - View commit details
-
Copy full SHA for a2ca192 - Browse repository at this point
Copy the full SHA a2ca192View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ab08f2 - Browse repository at this point
Copy the full SHA 2ab08f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3534246 - Browse repository at this point
Copy the full SHA 3534246View commit details -
Make CALL_ALLOC_AND_ENTER_INIT thread-safe
- Modify `get_init_for_simple_managed_python_class` to return both init as well as the type version at the time of lookup. - Modify caching logic to verify that the current version of the type matches the version at the time of lookup. This prevents potentially caching a stale value if we race with an update to __init__. - Only cache __init__ functions that are deferred in free-threaded builds. This ensures that the borrowed reference to __init__ that is stored in the cache is valid if the type version guard in _CHECK_AND_ALLOCATE_OBJECT passes: 1. The type version is cleared before the reference in the MRO to __init__ is destroyed. 2. If the reference in (1) was the last reference then the __init__ method will be queued for deletion the next time GC runs. 3. GC requires stopping the world, which forces a synchronizes-with operation between all threads. 4. If the GC collects the cached __init__, then type's version will have been updated *and* the update will be visible to all threads, so the guard cannot pass. - There are no escaping calls in between loading from the specialization cache and pushing the frame. This is a requirement for the default build.
Configuration menu - View commit details
-
Copy full SHA for acda1c6 - Browse repository at this point
Copy the full SHA acda1c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for fdfa678 - Browse repository at this point
Copy the full SHA fdfa678View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad2e15c - Browse repository at this point
Copy the full SHA ad2e15cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0003d00 - Browse repository at this point
Copy the full SHA 0003d00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ebd331 - Browse repository at this point
Copy the full SHA 8ebd331View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c1ad6c - Browse repository at this point
Copy the full SHA 4c1ad6cView commit details
Commits on Nov 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 57ba52d - Browse repository at this point
Copy the full SHA 57ba52dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ebd73d - Browse repository at this point
Copy the full SHA 8ebd73dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8651ebe - Browse repository at this point
Copy the full SHA 8651ebeView commit details
Commits on Nov 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4c7837f - Browse repository at this point
Copy the full SHA 4c7837fView commit details
Commits on Nov 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4b0a850 - Browse repository at this point
Copy the full SHA 4b0a850View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8a67c2 - Browse repository at this point
Copy the full SHA d8a67c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e8d85e - Browse repository at this point
Copy the full SHA 3e8d85eView commit details
Commits on Nov 26, 2024
-
Fix issue with
_CREATE_INIT_FRAME
Fix a bug in `_CREATE_INIT_FRAME` where the frame is pushed to the stack on failure. `_CREATE_INIT_FRAME` pushes a pointer to the new frame onto the stack for consumption by the next uop. When pushing the frame fails, we do not want to push the result (NULL) to the stack because it is not a valid stackref and will be exposed to the generic error handling code in the interpreter loop. This worked in default builds because `PyStackRef_NULL` is `NULL` in default builds, which is not the case in free-threaded builds.
Configuration menu - View commit details
-
Copy full SHA for de0e2ee - Browse repository at this point
Copy the full SHA de0e2eeView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.