-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint: Fix outstanding codespell spelling errors #3129
Conversation
I cannot uncheck reviewers added from |
Correction: I can but only after creating and undrafting a PR. |
Lint / Run pre-commit (pull_request)
Lint / Run pre-commit (pull_request)
To note, these were left unfixed in #3080, and we generally have a disinclination for mass typo-fix PRs. I'm not sure what the other editors think, though. A |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I'm fine with it, but as Adam said, we've generally avoided this sort of thing. And I recently suggested a typo fix to work around the repeated CI approval when iterating for a first-time contributor (#3095 (comment)).
But this PR is made now, we may as well merge it :)
I hope it's a once-in-a-lifetime fix. After that, we can change - extra_args: --all-files --hook-stage manual codespell || true
+ extra_args: --all-files --hook-stage manual codespell Edit: should I add the modification of |
No thanks, when this was added, we didn't want to enforce spellcheck on CI due to false positives: #2075 (comment) / #2075 (comment) / #2151 (review) / #2151 (comment) / etc. |
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: wookie184 <[email protected]>
Lint / Run pre-commit (pull_request)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, though seems like others have already done the hard work of reviewing this. As others have mentioned, we don't really want to encourage these kind of mass-typo-fix PR, but we may as well merge it. Hopefully they will be less common now that #3080 was implemented, though that thought might be rather optimistic and this will be a perpetual problem.
https://github.com/python/peps/actions/runs/4843117521/jobs/8630554766?pr=3128#step:5:87:
📚 Documentation preview 📚: https://pep-previews--3129.org.readthedocs.build/