Add syntax highlighting to NGINX config files #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zware
approved these changes
Nov 9, 2024
| @@ -0,0 +1,2 @@ | |||
| # Add syntax highlighting to NGINX config files | |||
| nginx.*.conf linguist-language=Nginx | |||
There was a problem hiding this comment.
I'm not sure how many wildcards this will take, but making it nginx*.conf* would also catch nginx.conf.jinja, for example.
There was a problem hiding this comment.
would that make us lose Jinja highlighting?
There was a problem hiding this comment.
I don't think so, because AFAICT we don't currently have any highlighting there :)
There was a problem hiding this comment.
Ah, I did find a counterexample in haproxy/config/nginx-redirect.conf.jinja, so maybe my suggestion is not a good one (though it would not actually catch that particular one).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny QoL improvement
I was linked to https://github.com/python/psf-salt/blob/main/salt/docs/config/nginx.docs-redirects.conf but there were no colors.
I've added a
.gitattributesto prompt GitHub to apply the NGINX syntax highlighting.ref: https://github.com/github-linguist/linguist/blob/main/docs/overrides.md
ref: https://github.com/github-linguist/linguist/blob/main/lib/linguist/languages.yml#L4712-L4727