Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for GSSAPI extension gss_inquire_sec_context_by_oid #128

Closed
wants to merge 1 commit into from

Conversation

vm86
Copy link

@vm86 vm86 commented Sep 25, 2017

Hello, I added a raw function : gss_inquire_sec_context_by_oid .

From this issues:
#51

was tested on the SMB protocol.

Copy link
Member

@DirectXMan12 DirectXMan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs better documentation, tests, and setup.py changes for the new module. Please let me know if you need guidance on doing any of this.

maj_stat = gss_inquire_sec_context_by_oid(&min_stat, context.raw_ctx, &mech.raw_oid, output_token_buffer_ptr)

if maj_stat == GSS_S_COMPLETE:
py_token = []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: py_tokens for clarity.


def inquire_sec_context_by_oid(SecurityContext context not None, OID mech not None):
"""
Args:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to follow the proper documentation format, including listing what it does, and what it returns. In general, python-gssapi documentation should be more-or-less usable without having to reference the main RFC.

Copy link
Member

@frozencemetery frozencemetery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your interest and code! CI failures are due to flake8, which needs to be passing.

@frozencemetery
Copy link
Member

Hi @vm86, are you still working on this? Is there anything we can help with?

@vm86
Copy link
Author

vm86 commented Dec 9, 2017

Hi @frozencemetery, yes, I work with, but heaven't time to do it. I need to write or find documentation for gss_inquire_sec_context_by_oid. Can you help me with?

@frozencemetery
Copy link
Member

Unfortunately, this function doesn't seem to have been documented on it's addition. When that happens, we tend to read the source or look for code that uses it. Then when other people want to know what a GSSAPI function does, they can come look at our documentation :)

Since presumably you need this function for something, you probably know what it does, right? Take a look at the docs for similar function inquire_cred_by_mech and try to match that.

@simo5
Copy link
Contributor

simo5 commented Dec 13, 2017

This function inquires a context for specific information not exposed by a standard GSSAPI call.
The OID represent the information requested. If the implementation (or the mechanism) supports inquiring for the specific information identified by the OID, then this information is returned as raw data in the returned buffer set.
The meaning of the raw data is dependent on the specific OID and is not defined as part of the API.

@vm86
Copy link
Author

vm86 commented Jan 13, 2018

I close, as done in: #141

@vm86 vm86 closed this Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants