This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
[1/x] clean up casting functions #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is a start of a cleanup of private casting functions in preparation for rowwise scaling. In this PR: 1. create `float8_scaling_utils.py` to unify functions which take a high precision tensor and return a float8 tensor, taking care of scaling 2. delete `Float8Tensor.to_float8` and move callsites to `ToFloat8ConstrFunc`, since the two functions do the same thing The end result is a slightly cleaner state, future PRs will do more cleanups. Test Plan: ``` ./test/test_everything.sh ``` Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
This was referenced Jul 26, 2024
facebook-github-bot
added
the
CLA Signed
|
@vkuzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@vkuzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This was referenced Jul 26, 2024
|
@vkuzo has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
drisspg
approved these changes
Jul 26, 2024
|
This pull request has been merged in 214da1f. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
This is a start of a cleanup of private casting functions in preparation for
rowwise scaling. In this PR:
float8_scaling_utils.pyto unify functions which take ahigh precision tensor and return a float8 tensor, taking care of
scaling
Float8Tensor.to_float8and move callsites toToFloat8ConstrFunc, since the two functions do the same thingThe end result is a slightly cleaner state, future PRs will do more
cleanups.
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D60291448