-
Notifications
You must be signed in to change notification settings - Fork 98
Fix python required version > 3.6 bug #144
base: master
Are you sure you want to change the base?
Conversation
Fix python required version > 3.6 bug
Hi @jenhaoyang! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
thanks for the PR! LGTM, just to clarify, this changes the torch dependency not python correct? if so could you edit the title of the PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kiukchung has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
No I think this is due to Python version problem. There is error shoing python version need to > 3.6 when I run docker build. However I would like to make minimum change so I choose to change Pytorch docker image version. |
I follow the documentation here https://pytorch.org/elastic/0.2.2/examples.html#multi-container
|
I see, FWIW torchelastic is already installed in the docker image: |
Get it. So for current situation would you think it would be better to remove the install torch elastic step in Dockrefile?
|
@jenhaoyang has updated the pull request. You must reimport the pull request before landing. |
No description provided.