Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyTorch Profiler [WIP] #2906

Draft
wants to merge 22 commits into
base: master
Choose a base branch
from
Draft

Conversation

guptaaryan16
Copy link
Contributor

Fixes #1917
(uses #2315)

Description: Added check for minimum version of PyTorch for import. Now need to add tests for the Profiler

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: handlers Core Handlers module label Apr 1, 2023
@guptaaryan16
Copy link
Contributor Author

Hey @vfdev-5 @sdesrozis I have added a check for minimum PyTorch version, Now I wanted to ask whether we should keep this profiler in the main module or in the contrib module as most of the handlers introduced afterwards were put there. Also what should be the additional tests that should be present in this handler?

@guptaaryan16 guptaaryan16 marked this pull request as draft June 28, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: handlers Core Handlers module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce an handler to use new profiler
3 participants