Add logging of mappings in BaseLogger #3295
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before testing this, I would like to be sure the feature is of interest. |
vfdev-5
reviewed
Oct 17, 2024
|
@vfdev-5 is it ok for you like that? If so, I'll fix the linting and adapt the tests |
vfdev-5
reviewed
Oct 22, 2024
| return metrics | ||
|
|
||
| @classmethod | ||
| def _compute_tags( |
There was a problem hiding this comment.
You can make this just a private helper method in this submodule, not necessarily a classmethod.
Comment on lines
+169
to
+172
| concat_tf: Callable[..., Union[str, Tuple[str, ...]]], | ||
| log_text: bool, node: Iterable[Tuple[str, Any]], | ||
| parent_tag: Union[str, Tuple[str, ...]], | ||
| dest_dict: Dict[Any, Union[str, float, numbers.Number]] |
There was a problem hiding this comment.
I'm not keen of passing dest_dict as the argument, but maybe we can't do anything better here...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3294
Description:
Adds support for
Mappingmetrics in loggersCheck list: