Ks/#1441 test crepl fork #1442
Open
Ks/#1441 test crepl fork #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSchopmeyer
force-pushed
the
ks/#1441-test-crepl-fork
branch
2 times, most recently
from
62dfbca
to
c5e8bf5
Compare
Test change to be submitted to click_repl to enable use of general options in the repl.
KSchopmeyer
force-pushed
the
ks/#1441-test-crepl-fork
branch
from
c5e8bf5
to
2811ffd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test with fork of click-repl to determine if we can fix issue with not allowing use of general options.
Status: TBD
Conclusion: The change itself works but the current code is a hack just to determine if we modify the existing click-repl to allow use of the general options on as part of the repl cmd input.
Conclusion: yes we can.
DISCUSSION:
However there are some questions here since the process of getting any changes through the review process of click-repl (i.e. can take years since nobody really working that part of their issues).
Question: Best way to include their changes as part of our next release. Right now it is a fork of git-repl and the requirements.txt just references that github repo and branch. For the moment I put it into my own branch.