Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added alt text for user Avatar #902

Closed
wants to merge 1 commit into from
Closed

Added alt text for user Avatar #902

wants to merge 1 commit into from

Conversation

MominRaza
Copy link

Ex.: Momin's avatar
#901

@MominRaza
Added alt text for user Avatar
0d7151f 
Ex.: Momin's avatar
phy25
phy25 suggested changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@phy25 phy25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this alt text be translatable?

@MominRaza
Copy link
Author

it will but we need more core changes in lang files

@MominRaza
Copy link
Author

I didn't realized that I'm adding alt text for anchor tag instead of img tag. Shortly I will create a another pull request with right code.

@MominRaza MominRaza closed this Jul 16, 2021
@MominRaza MominRaza mentioned this pull request Jul 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phy25 phy25 phy25 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MominRaza @phy25