Merge pull request #1663 from qdraw/feature/202408-GeoParser-timeout

fix timeout

starsky/starsky.foundation.readmeta/Helpers/GeoParser.cs

@@ -5,6 +5,18 @@
 
 namespace starsky.foundation.readmeta.Helpers
 {
+	internal static partial class GeoParserInvalidCharactersRegex
+	{
+		/// <summary>
+		///  Generated regex for removing invalid characters
+		/// </summary>
+		/// <returns></returns>
+		[GeneratedRegex("[^0-9\\., ]", 
+			RegexOptions.CultureInvariant, 
+			matchTimeoutMilliseconds: 1000)]
+		public static partial Regex GetRegex();
+	}
+
 	public static class GeoParser
 	{
 
@@ -19,12 +31,11 @@ public static double ConvertDegreeMinutesSecondsToDouble(string point, string re
 			//Example: 17.21.18S
 			// DD°MM’SS.s” usage
 
-			var multiplier = ( refGps.Contains('S') || refGps.Contains('W') ) ? -1 : 1; //handle south and west
-
-			point = Regex.Replace(point, "[^0-9\\., ]", "", RegexOptions.CultureInvariant,
-				TimeSpan.FromMilliseconds(100)); //remove the characters
+			var multiplier = ( refGps.Contains('S') || refGps.Contains('W') ) ? -1 : 1; // handle south and west
+
+			point = GeoParserInvalidCharactersRegex.GetRegex().Replace(point, ""); // remove the characters
 
-			// When you use an localisation where commas are used instead of a dot
+			// When you use a localisation where commas are used instead of a dot
 			point = point.Replace(",", ".");
 
 			var pointArray = point.Split(' '); //split the string.
@@ -53,8 +64,7 @@ public static double ConvertDegreeMinutesToDouble(string point, string refGps)
 			var multiplier = ( refGps.Contains('S') || refGps.Contains('W') ) ? -1 : 1; // handle south and west
 
 			point = point.Replace(",", " ");
-			point = Regex.Replace(point, "[^0-9\\., ]", "", RegexOptions.CultureInvariant,
-				 TimeSpan.FromMilliseconds(100)); //remove the characters
+			point = GeoParserInvalidCharactersRegex.GetRegex().Replace(point, ""); // remove the characters
 
 			var pointArray = point.Split(' '); //split the string.
 			var degrees = double.Parse(pointArray[0], CultureInfo.InvariantCulture);
@@ -98,7 +108,7 @@ public static GeoListItem ParseIsoString(string isoStr)
 			isoStr = isoStr.Remove(isoStr.Length - 1); // Remove trailing slash
 
 			var parts = isoStr.Split(Separator, StringSplitOptions.None);
-			if ( parts.Length < 3 || parts.Length > 4 )
+			if ( parts.Length is < 3 or > 4 )
 			{
 				// Check for parts count
 				return geoListItem;