Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRA -> Vite - frontend migratie #1204

Merged
merged 51 commits into from
Oct 4, 2023
Merged

CRA -> Vite - frontend migratie #1204

merged 51 commits into from
Oct 4, 2023

Conversation

qdraw
Copy link
Owner

@qdraw qdraw commented Aug 8, 2023

PR Details

Description / Motivation and Context

TOdo

Related Issue

How Has This Been Tested

  • C# Unit tests
  • Typescript Unit tests
  • Other Unit tests
  • Manual tests
  • Automatic End2end tests (starsky-tools/end2end)

Types of changes

  • Added for new features
  • Breaking change fix or feature that would cause existing functionality to change
  • Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
  • Deprecated for soon-to-be removed features
  • Removed for now removed features
  • Fixed for any bug fixes
  • Security in case of vulnerabilities

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (update when needed)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the ./history.md document

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (cb56ee1) 93.99% compared to head (5e6ba41) 94.48%.
Report is 28 commits behind head on master.

❗ Current head 5e6ba41 differs from pull request most recent head 599e499. Consider uploading reports for the commit 599e499 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1204      +/-   ##
==========================================
+ Coverage   93.99%   94.48%   +0.48%     
==========================================
  Files         548      567      +19     
  Lines       18916    20150    +1234     
  Branches     3135     3143       +8     
==========================================
+ Hits        17781    19039    +1258     
- Misses        618      743     +125     
+ Partials      517      368     -149     
Flag Coverage Δ
all 94.48% <94.73%> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../starsky.foundation.platform/Models/AppSettings.cs 94.31% <ø> (-0.03%) ⬇️
...l-aperture/detailview-info-make-model-aperture.tsx 100.00% <ø> (ø)
...ntapp/src/components/atoms/drop-area/drop-area.tsx 84.37% <ø> (+3.34%) ⬆️
...mponents/atoms/file-hash-image/file-hash-image.tsx 100.00% <100.00%> (ø)
...nents/atoms/file-hash-image/pan-and-zoom-image.tsx 81.13% <ø> (-5.83%) ⬇️
...components/atoms/flat-list-item/flat-list-item.tsx 100.00% <ø> (ø)
...ms/hamburger-menu-toggle/hamburger-menu-toggle.tsx 100.00% <ø> (ø)
...arsky/clientapp/src/components/atoms/link/link.tsx 100.00% <100.00%> (ø)
...ms/list-image-child-item/list-image-child-item.tsx 100.00% <ø> (ø)
...app/src/components/atoms/list-image/list-image.tsx 92.30% <100.00%> (+1.98%) ⬆️
... and 112 more

... and 75 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qdraw qdraw changed the title Vite CRA -> Vite - frontend migratie Aug 14, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.2% 97.2% Coverage
0.0% 0.0% Duplication

@qdraw qdraw merged commit 9ae18c1 into master Oct 4, 2023
25 checks passed
@qdraw qdraw deleted the feature/202308_vite branch October 4, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant