code smells #1264

qdraw · 2023-10-21T09:21:24Z

PR Details

Description / Motivation and Context

Related Issue

How Has This Been Tested

Types of changes

Added for new features
Breaking change fix or feature that would cause existing functionality to change
Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
Deprecated for soon-to-be removed features
Removed for now removed features
Fixed for any bug fixes
Security in case of vulnerabilities

Checklist

My code follows the code style of this project.
I have updated the documentation accordingly (update when needed)
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.
I have updated the ./history.md document

codecov · 2023-10-21T09:34:03Z

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (47618d2) 94.48% compared to head (46cd26a) 94.51%.
Report is 9 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1264      +/-   ##
==========================================
+ Coverage   94.48%   94.51%   +0.03%     
==========================================
  Files         567      567              
  Lines       20149    20157       +8     
  Branches     3143     3147       +4     
==========================================
+ Hits        19038    19052      +14     
+ Misses        743      737       -6     
  Partials      368      368

Flag	Coverage Δ
all	`94.51% <92.68%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...arsky.feature.search/ViewModels/SearchViewModel.cs	`94.29% <100.00%> (+2.85%)`	⬆️
....foundation.database/Helpers/SetupDatebaseTypes.cs	`96.61% <100.00%> (+1.69%)`	⬆️
...tarsky.foundation.database/Models/FileIndexItem.cs	`94.32% <100.00%> (+0.02%)`	⬆️
...foundation.readmeta/ReadMetaHelpers/ReadMetaXmp.cs	`97.12% <100.00%> (ø)`
...l-aperture/detailview-info-make-model-aperture.tsx	`100.00% <ø> (ø)`
...mponents/atoms/file-hash-image/file-hash-image.tsx	`100.00% <ø> (ø)`
...sky/clientapp/src/components/atoms/modal/modal.tsx	`100.00% <100.00%> (ø)`
...c/components/atoms/switch-button/switch-button.tsx	`100.00% <ø> (ø)`
.../molecules/search-pagination/search-pagination.tsx	`90.24% <ø> (ø)`
...ailview-info-datetime/detailview-info-datetime.tsx	`94.44% <100.00%> (ø)`
... and 10 more