Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[not supported yet] Feature/202401 open telemetry clientside #1329

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

qdraw
Copy link
Owner

@qdraw qdraw commented Jan 7, 2024

PR Details

Description / Motivation and Context

npm install --save @opentelemetry/api
npm install --save @opentelemetry/sdk-trace-web
npm install --save @opentelemetry/exporter-trace-otlp-http
npm install --save @opentelemetry/auto-instrumentations-web
npm install --save @opentelemetry/context-zone
npm install --save @opentelemetry/resources
npm install --save @opentelemetry/semantic-conventions
npm install --save @opentelemetry/instrumentation
npm install --save @opentelemetry/instrumentation-fetch

Related Issue

How Has This Been Tested

  • C# Unit tests
  • Typescript Unit tests
  • Other Unit tests
  • Manual tests
  • Automatic End2end tests (starsky-tools/end2end)

Types of changes

  • Added for new features
  • Breaking change fix or feature that would cause existing functionality to change
  • Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
  • Deprecated for soon-to-be removed features
  • Removed for now removed features
  • Fixed for any bug fixes
  • Security in case of vulnerabilities

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (update when needed)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the ./history.md document

@qdraw qdraw linked an issue Jan 9, 2024 that may be closed by this pull request
qdraw added 2 commits February 3, 2024 11:02
# Conflicts:
#	starsky/starsky.foundation.webtelemetry/starsky.foundation.webtelemetry.csproj
#	starsky/starsky/clientapp/package-lock.json
#	starsky/starsky/clientapp/package.json
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (e19559d) 95.39% compared to head (0cf1e8d) 95.10%.
Report is 1 commits behind head on master.

Files Patch % Lines
....foundation.webtelemetry/Services/TracesService.cs 29.62% 19 Missing ⚠️
...ky.foundation.webtelemetry/GeneratedCode/Common.cs 56.09% 16 Missing and 2 partials ⚠️
...ientapp/src/shared/opentelemetry/opentelemetry.tsx 0.00% 16 Missing ⚠️
...sky/starsky/Controllers/OpenTelemetryController.cs 6.66% 14 Missing ⚠️
...sky.foundation.webtelemetry/GeneratedCode/Trace.cs 83.33% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1329      +/-   ##
==========================================
- Coverage   95.39%   95.10%   -0.30%     
==========================================
  Files         596      602       +6     
  Lines       22131    22275     +144     
  Branches     4117     4137      +20     
==========================================
+ Hits        21112    21184      +72     
- Misses        635      705      +70     
- Partials      384      386       +2     
Flag Coverage Δ
all 95.10% <48.61%> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qdraw qdraw changed the title Feature/202401 open telemetry clientside [not supported yet] Feature/202401 open telemetry clientside Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenTelemetry instead of Application Insights
1 participant