Removal of hard dependency of Application Insights > Open Telemetry

.editorconfig

@@ -45,7 +45,7 @@ csharp_new_line_before_members_in_anonymous_types = true
 csharp_new_line_within_query_expression_clauses = true
 csharp_wrap_before_eq = false
 place_attribute_on_same_line = "never"
-csharp_style_namespace_declarations = file_scoped:warning
+# csharp_style_namespace_declarations = file_scoped:warning
 
 # Indentation preferences
 csharp_indent_block_contents = true
@@ -65,3 +65,10 @@ dotnet_code_quality_unused_parameters = all:warning
 dotnet_remove_unnecessary_suppression_exclusions = none:warning
 
 dotnet_style_namespace_match_folder = true:suggestion
+
+# unused usings
+dotnet_diagnostic.IDE0005.severity = warning
+
+# CS4014: Because this call is not awaited, execution of the current method continues before the call is completed.
+# Consider applying the 'await' operator to the result of the call.
+dotnet_diagnostic.CS4014.severity = error

documentation/Program.cs

@@ -1,20 +1,19 @@
 using System.Diagnostics;
 
-static string  GetSolutionParentFolder()
+static string GetSolutionParentFolder()
 {
 	var strExeFilePath = System.Reflection.Assembly.GetExecutingAssembly().Location;
-	return Path.GetDirectoryName(Path.GetDirectoryName(Path.GetDirectoryName(Path.GetDirectoryName(strExeFilePath))))!;
+	return Path.GetDirectoryName(
+		Path.GetDirectoryName(Path.GetDirectoryName(Path.GetDirectoryName(strExeFilePath))))!;
 }
 
 static Process NpmCommand(string command)
 {
-	var startInfo = new ProcessStartInfo()
+	var startInfo = new ProcessStartInfo
 	{
-		FileName = "npm", 
-		Arguments = command,
-		WorkingDirectory = GetSolutionParentFolder()
-	}; 
-	var proc = new Process() { StartInfo = startInfo };
+		FileName = "npm", Arguments = command, WorkingDirectory = GetSolutionParentFolder()
+	};
+	var proc = new Process { StartInfo = startInfo };
 	return proc;
 }
 

documentation/docs/developer-guide/contributing/SECURITY.md

@@ -7,7 +7,8 @@ Breaking changes are reported in the [changelog/history](https://docs.qdraw.nl/d
 
 | Version | Supported          |
 |---------|--------------------|
-| 0.5.x   | :white_check_mark: |
+| 0.6.x   | :white_check_mark: |
+| 0.5.x   | :x:                |
 | 0.4.x   | :x:                |
 | < 0.3   | :x:                |
 

documentation/static/openapi/openapi.json

@@ -4501,39 +4501,6 @@
       "parameters": [],
       "extensions": {}
     },
-    "/api/health/application-insights": {
-      "operations": {
-        "Get": {
-          "tags": [
-            {
-              "name": "Health",
-              "extensions": {},
-              "unresolvedReference": false
-            }
-          ],
-          "summary": "Add Application Insights script to user context",
-          "parameters": [],
-          "responses": {
-            "200": {
-              "description": "Ok",
-              "headers": {},
-              "content": {},
-              "links": {},
-              "extensions": {},
-              "unresolvedReference": false
-            }
-          },
-          "callbacks": {},
-          "deprecated": false,
-          "security": [],
-          "servers": [],
-          "extensions": {}
-        }
-      },
-      "servers": [],
-      "parameters": [],
-      "extensions": {}
-    },
     "/api/health/version": {
       "operations": {
         "Post": {
@@ -11856,54 +11823,6 @@
             "extensions": {},
             "unresolvedReference": false
           },
-          "applicationInsightsConnectionString": {
-            "type": "string",
-            "readOnly": false,
-            "writeOnly": false,
-            "allOf": [],
-            "oneOf": [],
-            "anyOf": [],
-            "required": [],
-            "properties": {},
-            "additionalPropertiesAllowed": true,
-            "enum": [],
-            "nullable": true,
-            "deprecated": false,
-            "extensions": {},
-            "unresolvedReference": false
-          },
-          "applicationInsightsLog": {
-            "type": "boolean",
-            "readOnly": false,
-            "writeOnly": false,
-            "allOf": [],
-            "oneOf": [],
-            "anyOf": [],
-            "required": [],
-            "properties": {},
-            "additionalPropertiesAllowed": true,
-            "enum": [],
-            "nullable": true,
-            "deprecated": false,
-            "extensions": {},
-            "unresolvedReference": false
-          },
-          "applicationInsightsDatabaseTracking": {
-            "type": "boolean",
-            "readOnly": false,
-            "writeOnly": false,
-            "allOf": [],
-            "oneOf": [],
-            "anyOf": [],
-            "required": [],
-            "properties": {},
-            "additionalPropertiesAllowed": true,
-            "enum": [],
-            "nullable": true,
-            "deprecated": false,
-            "extensions": {},
-            "unresolvedReference": false
-          },
           "maxDegreesOfParallelism": {
             "type": "integer",
             "format": "int32",

pipelines/azure/app-ci.yml

@@ -62,6 +62,7 @@ stages:
     - template: /pipelines/azure/steps/build_server.yml
       parameters:
         vstest: false
+        readyToRunEnabled: true
         runtimeArg: '--runtime "win-x64,linux-x64,osx-x64,osx-arm64"'
         nugetPackages: $(NUGET_PACKAGES)
 

pipelines/azure/steps/build_server.yml

@@ -6,6 +6,9 @@ parameters:
   nugetPackages: $(Pipeline.Workspace)/.nuget/packages
 
 steps:
+  - template: /pipelines/azure/steps/cache_nuget_packages.yml
+  - template: /pipelines/azure/steps/cache_dependencies.yml
+
   - task: DotNetCoreCLI@2
     displayName: "[Nuke/server] dotnet tool restore"
     continueOnError: true
@@ -14,11 +17,8 @@ steps:
       custom: tool
       arguments: "restore --tool-manifest starsky/.config/dotnet-tools.json"
 
-  - template: /pipelines/azure/steps/cache_nuget_packages.yml
-  - template: /pipelines/azure/steps/cache_dependencies.yml
-
   - task: PowerShell@2
-    displayName: "Nuke SonarBuildTest (with tests) "
+    displayName: "Nuke SonarBuildTest (with tests)"
     condition: and(succeeded(), eq('${{ parameters.vstest }}', true) )
     env:
       BUILD_SOURCEBRANCH: $(Build.SourceBranch)

pipelines/azure/steps/use_dotnet_version.yml

@@ -1,6 +1,6 @@
 steps:
   - task: UseDotNet@2
-    displayName: 'Use .NET Core sdk 8.0.101'
+    displayName: 'Use .NET SDK 8.0.101'
     enabled: true
     inputs:
       packageType: sdk

starsky-tools/build-tools/dotnet-sdk-version-update.js

@@ -419,7 +419,7 @@ async function updateAzureYmlFile(filePathList, sdkVersion) {
 					fileContent = fileContent.replace(
 						displayNameTagRegex,
 						displayNameTag +
-							"'Use .NET Core sdk " +
+							"'Use .NET SDK " +
 							sdkVersion +
 							"'"
 					);

starsky/Directory.Build.props

@@ -1,9 +1,15 @@
 <Project>
-  <PropertyGroup>
-    <RuntimeIdentifier Condition="'$(OverwriteRuntimeIdentifier)' != ''">$(OverwriteRuntimeIdentifier)</RuntimeIdentifier>
-    <SelfContained Condition="'$(OverwriteRuntimeIdentifier)' != ''">true</SelfContained>
-    <Copyright>"Copyright (c) 2018 - $([System.DateTime]::Now.ToString(`yyyy`)) Qdraw and other authors"</Copyright>
-    <Authors>Qdraw and contributors</Authors>
-    <Company>Qdraw</Company>
-  </PropertyGroup>
+    <PropertyGroup>
+        <RuntimeIdentifier Condition="'$(OverwriteRuntimeIdentifier)' != ''">$(OverwriteRuntimeIdentifier)</RuntimeIdentifier>
+        <SelfContained Condition="'$(OverwriteRuntimeIdentifier)' != ''">true</SelfContained>
+        <Copyright>"Copyright (c) 2018 - $([System.DateTime]::Now.ToString(`yyyy`)) Qdraw and other authors"</Copyright>
+        <Authors>Qdraw and contributors</Authors>
+        <Company>Qdraw</Company>
+    </PropertyGroup>
+    <PropertyGroup>
+        <GenerateDocumentationFile>true</GenerateDocumentationFile>
+        <NoWarn>$(NoWarn);CS1591;CS1573</NoWarn>
+        <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
+    </PropertyGroup>
+
 </Project>

starsky/build/Build.cs

@@ -64,7 +64,7 @@ public sealed class Build : NukeBuild
 	/// Nuget & NPM dependencies are always installed
 	/// </summary>
 	[Parameter("Skip Dependencies download e.g. exiftool / " +
-	           "geo data, nuget/npm deps are always installed")]
+			   "geo data, nuget/npm deps are always installed")]
 	readonly bool NoDependencies;
 
 	/// <summary>
@@ -94,7 +94,7 @@ bool IsPublishDisabled()
 	/// </summary>
 	/// <returns>only if overwritten</returns>
 	[Parameter("Overwrite branch name")]
-	readonly string Branch;
+	readonly string Branch = string.Empty;
 
 	/// <summary>
 	/// Overwrite Branch name
@@ -104,7 +104,7 @@ string GetBranchName()
 	{
 		var branchName = Branch;
 		if ( !string.IsNullOrEmpty(branchName) &&
-		     branchName.StartsWith("refs/heads/") )
+			 branchName.StartsWith("refs/heads/") )
 		{
 			branchName = branchName.Replace("refs/heads/", "");
 		}
@@ -147,7 +147,7 @@ List<string> GetRuntimesWithoutGeneric()
 	/// Solution .sln file
 	/// </summary>
 	[Solution(SuppressBuildProjectCheck = true)]
-	readonly Solution Solution;
+	readonly Solution Solution = new();
 
 	/// <summary>
 	/// List of output projects
@@ -236,7 +236,7 @@ void ShowSettingsInfo()
 			$"Current RID: {RuntimeIdentifier.GetCurrentRuntimeIdentifier()}");
 
 		Log.Information("SolutionParentFolder: " +
-		                WorkingDirectory.GetSolutionParentFolder());
+						WorkingDirectory.GetSolutionParentFolder());
 
 		Log.Information(NoClient
 			? "Client is: disabled"
@@ -251,8 +251,8 @@ void ShowSettingsInfo()
 			: "Publish: enabled");
 
 		Log.Information(NoSonar ||
-		                string.IsNullOrEmpty(SonarQube.GetSonarKey()) ||
-		                string.IsNullOrEmpty(SonarQube.GetSonarToken())
+						string.IsNullOrEmpty(SonarQube.GetSonarKey()) ||
+						string.IsNullOrEmpty(SonarQube.GetSonarToken())
 			? "Sonarcloud scan: disabled"
 			: "Sonarcloud scan: enabled");
 
@@ -311,7 +311,7 @@ void ShowSettingsInfo()
 				Configuration);
 			DotnetTestHelper.TestNetCoreGenericCommand(Configuration,
 				IsUnitTestDisabled());
-			DotnetGenericHelper.DownloadDependencies(Configuration, GeoCliCsproj, 
+			DotnetGenericHelper.DownloadDependencies(Configuration, GeoCliCsproj,
 				NoDependencies, GenericRuntimeName);
 			MergeCoverageFiles.Merge(IsUnitTestDisabled());
 			SonarQube.SonarEnd(IsUnitTestDisabled(), NoSonar);

starsky/build/_build.csproj

@@ -1,35 +1,35 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
-  <PropertyGroup>
-    <OutputType>Exe</OutputType>
-    <TargetFramework>net8.0</TargetFramework>
-    <RootNamespace />
-    <NoWarn>CS0649;CS0169</NoWarn>
-    <NukeRootDirectory>..</NukeRootDirectory>
-    <NukeScriptDirectory>..</NukeScriptDirectory>
-    <NukeTelemetryVersion>1</NukeTelemetryVersion>
-    <!-- https://github.com/nuke-build/nuke/issues/818 -->
-    <EnableUnsafeBinaryFormatterSerialization>true</EnableUnsafeBinaryFormatterSerialization>
-  </PropertyGroup>
+    <PropertyGroup>
+        <OutputType>Exe</OutputType>
+        <TargetFramework>net8.0</TargetFramework>
+        <RootNamespace/>
+        <NoWarn>CS0649;CS0169</NoWarn>
+        <NukeRootDirectory>..</NukeRootDirectory>
+        <NukeScriptDirectory>..</NukeScriptDirectory>
+        <NukeTelemetryVersion>1</NukeTelemetryVersion>
+        <Nullable>enable</Nullable>
+        <ProjectGuid>{b0a4bfd3-6321-4962-a15c-142aace9a4c9}</ProjectGuid>
+    </PropertyGroup>
 
-  <ItemGroup>
-    <PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="8.0.1" />
-    <PackageReference Include="Microsoft.Extensions.FileSystemGlobbing" Version="8.0.0" />
-    <PackageReference Include="Nuke.Common" Version="7.0.6" />
-    <PackageReference Include="ReportGenerator.Core" Version="5.2.0" />
-    <PackageReference Include="SimpleExec" Version="11.0.0" />
-  </ItemGroup>
+    <ItemGroup>
+        <PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="8.0.1"/>
+        <PackageReference Include="Microsoft.Extensions.FileSystemGlobbing" Version="8.0.0"/>
+        <PackageReference Include="Nuke.Common" Version="8.0.0" />
+        <PackageReference Include="ReportGenerator.Core" Version="5.2.1" />
+        <PackageReference Include="SimpleExec" Version="12.0.0" />
+    </ItemGroup>
 
-  <ItemGroup>
-    <Compile Remove="logs\**" />
-  </ItemGroup>
+    <ItemGroup>
+        <Compile Remove="logs\**"/>
+    </ItemGroup>
 
-  <ItemGroup>
-    <EmbeddedResource Remove="logs\**" />
-  </ItemGroup>
+    <ItemGroup>
+        <EmbeddedResource Remove="logs\**"/>
+    </ItemGroup>
+
+    <ItemGroup>
+        <None Remove="logs\**"/>
+    </ItemGroup>
 
-  <ItemGroup>
-    <None Remove="logs\**" />
-  </ItemGroup>
-
 </Project>

starsky/build/helpers/ClientHelper.cs

@@ -6,7 +6,7 @@
 
 namespace helpers
 {
-	
+
 	public static class ClientHelper
 	{
 		public static string GetClientAppFolder()
@@ -20,26 +20,26 @@ public static string GetClientAppFolder()
 				throw new DirectoryNotFoundException("rootDirectory is null, this is wrong");
 			return Path.Combine(rootDirectory, ClientAppFolder);
 		}
-	
+
 		public static void NpmPreflight()
 		{
 			Log.Information("Checking if Npm (and implicit: Node) is installed, will fail if not on this step");
 			Run(NpmBaseCommand, "-v");
-			
+
 			Log.Information("Checking if Node is installed, will fail if not on this step");
 			Run(NodeBaseCommand, "-v");
-		}	
-	
+		}
+
 		public static void ClientCiCommand()
 		{
 			Run(NpmBaseCommand, "ci --legacy-peer-deps --prefer-offline --no-audit --no-fund", GetClientAppFolder());
 		}
-	
+
 		public static void ClientBuildCommand()
 		{
 			Run(NpmBaseCommand, "run build", GetClientAppFolder());
 		}
-	
+
 		public static void ClientTestCommand()
 		{
 			Run(NpmBaseCommand, "run test:ci", GetClientAppFolder());