Fix msg_data type (#2275)

qdrvm · Nov 15, 2024 · 153ed85 · 153ed85
1 parent 2a0045f
commit 153ed85
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 8 deletions.
diff --git a/core/host_api/host_api.hpp b/core/host_api/host_api.hpp
@@ -413,7 +413,7 @@ namespace kagome::host_api {
     [[nodiscard]] virtual runtime::WasmSpan
     ext_crypto_ecdsa_sign_prehashed_version_1(runtime::WasmSize key_type,
                                               runtime::WasmPointer key,
-                                              runtime::WasmSpan msg_data) = 0;
+                                              runtime::WasmPointer msg_data) = 0;
 
     /**
      * @brief Generates an ecdsa key for the given key type using an optional

diff --git a/core/host_api/impl/crypto_extension.cpp b/core/host_api/impl/crypto_extension.cpp
@@ -616,14 +616,14 @@ namespace kagome::host_api {
   runtime::WasmSpan CryptoExtension::ext_crypto_ecdsa_sign_prehashed_version_1(
       runtime::WasmPointer key_type_ptr,
       runtime::WasmPointer key,
-      runtime::WasmSpan msg) {
+      runtime::WasmPointer msg_data) {
     using ResultType = std::optional<crypto::EcdsaSignature>;
 
     crypto::KeyType key_type = loadKeyType(key_type_ptr);
     checkIfKeyIsSupported(key_type, logger_);
 
     auto public_buffer = getMemory().loadN(key, sizeof(crypto::EcdsaPublicKey));
-    auto [msg_data, msg_len] = runtime::PtrSize(msg);
+    runtime::WasmSize msg_len = 32;
     auto msg_buffer = getMemory().loadN(msg_data, msg_len);
 
     crypto::EcdsaPublicKey pk;

diff --git a/core/host_api/impl/crypto_extension.hpp b/core/host_api/impl/crypto_extension.hpp
@@ -213,7 +213,7 @@ namespace kagome::host_api {
     runtime::WasmSpan ext_crypto_ecdsa_sign_prehashed_version_1(
         runtime::WasmPointer key_type,
         runtime::WasmPointer key,
-        runtime::WasmSpan msg);
+        runtime::WasmPointer msg);
 
     /**
      * @see HostApi::ext_crypto_ecdsa_generate

diff --git a/core/host_api/impl/host_api_impl.cpp b/core/host_api/impl/host_api_impl.cpp
@@ -341,7 +341,7 @@ namespace kagome::host_api {
   runtime::WasmSpan HostApiImpl::ext_crypto_ecdsa_sign_prehashed_version_1(
       runtime::WasmSize key_type,
       runtime::WasmPointer key,
-      runtime::WasmSpan msg_data) {
+      runtime::WasmPointer msg_data) {
     return crypto_ext_.ext_crypto_ecdsa_sign_prehashed_version_1(
         key_type, key, msg_data);
   }

diff --git a/core/host_api/impl/host_api_impl.hpp b/core/host_api/impl/host_api_impl.hpp
@@ -190,7 +190,7 @@ namespace kagome::host_api {
     runtime::WasmSpan ext_crypto_ecdsa_sign_prehashed_version_1(
         runtime::WasmSize key_type,
         runtime::WasmPointer key,
-        runtime::WasmSpan msg_data) override;
+        runtime::WasmPointer msg_data) override;
 
     runtime::WasmPointer ext_crypto_ecdsa_generate_version_1(
         runtime::WasmSize key_type_id, runtime::WasmSpan seed) override;

diff --git a/core/runtime/common/register_host_api.hpp b/core/runtime/common/register_host_api.hpp
@@ -35,7 +35,7 @@
     REGISTER_HOST_METHOD(int32_t, ext_crypto_sr25519_verify_version_2, int32_t, int64_t, int32_t) \
     REGISTER_HOST_METHOD(int64_t, ext_crypto_ecdsa_public_keys_version_1, int32_t) \
     REGISTER_HOST_METHOD(int64_t, ext_crypto_ecdsa_sign_version_1, int32_t, int32_t, int64_t) \
-    REGISTER_HOST_METHOD(int64_t, ext_crypto_ecdsa_sign_prehashed_version_1, int32_t, int32_t, int64_t) \
+    REGISTER_HOST_METHOD(int64_t, ext_crypto_ecdsa_sign_prehashed_version_1, int32_t, int32_t, int32_t) \
     REGISTER_HOST_METHOD(int32_t, ext_crypto_ecdsa_generate_version_1, int32_t, int64_t) \
     REGISTER_HOST_METHOD(int32_t, ext_crypto_ecdsa_verify_version_1, int32_t, int64_t, int32_t) \
     REGISTER_HOST_METHOD(int32_t, ext_crypto_ecdsa_verify_prehashed_version_1, int32_t, int32_t, int32_t) \

diff --git a/test/mock/core/host_api/host_api_mock.hpp b/test/mock/core/host_api/host_api_mock.hpp
@@ -290,7 +290,7 @@ namespace kagome::host_api {
                 ext_crypto_ecdsa_sign_prehashed_version_1,
                 (runtime::WasmSize key_type,
                  runtime::WasmPointer key,
-                 runtime::WasmSpan msg_data),
+                 runtime::WasmPointer msg_data),
                 (override));
 
     MOCK_METHOD(runtime::WasmPointer,