Fix zombienet test (#1840)

* fix: false negative approval checking result Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
qdrvm · Oct 10, 2023 · bcf4fe9 · bcf4fe9
1 parent e55bef8
commit bcf4fe9
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/core/crypto/crypto_store/key_type.hpp b/core/crypto/crypto_store/key_type.hpp
@@ -18,7 +18,7 @@ namespace kagome::crypto {
   };
 
   /**
-   * Makes 32bit integer uin which represent encoded 4-char strings
+   * Makes 32bit integer which represent encoded 4-char strings
    * Little-endian byte order is used
    */
   constexpr uint32_t operator""_key(const char *s, std::size_t size) {

diff --git a/core/parachain/approval/approval_distribution.cpp b/core/parachain/approval/approval_distribution.cpp
@@ -1289,7 +1289,7 @@ namespace kagome::parachain {
             self->logger_->warn(
                 "Parachain data recovery failed.(error={}, session index={}, "
                 "candidate hash={}, relay block hash={})",
-                opt_result->error().message(),
+                opt_result->error(),
                 session_index,
                 candidate_hash,
                 relay_block_hash);

diff --git a/core/parachain/availability/recovery/recovery_impl.cpp b/core/parachain/availability/recovery/recovery_impl.cpp
@@ -160,8 +160,7 @@ namespace kagome::parachain {
     }
     if (active.chunks.size() + active.chunks_active + active.order.size()
         < active.chunks_required) {
-      return done(
-          lock, it, toErasureCodingError(ec_cpp::Error::kNeedMoreShards));
+      return done(lock, it, std::nullopt);
     }
     auto max = std::min(kParallelRequests,
                         active.chunks_required - active.chunks.size());