Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/prospective parachains multi candidates #1996

Merged
merged 16 commits into from
Apr 7, 2024

Conversation

iceseer
Copy link
Contributor

@iceseer iceseer commented Mar 1, 2024

Closes #1993

Description of the Change

Provide multiple candidates from fragment tree

Ref: paritytech/polkadot-sdk#3160

@iceseer iceseer requested review from xDimon and kamilsa March 4, 2024 12:32
@iceseer iceseer force-pushed the feature/prospective_parachains_multi_candidates branch from 0cc14d5 to 4d59039 Compare March 6, 2024 15:33
@iceseer iceseer force-pushed the feature/prospective_parachains_multi_candidates branch from 4d59039 to 0c43fea Compare March 6, 2024 15:50
iceseer and others added 7 commits March 6, 2024 18:58
Signed-off-by: iceseer <[email protected]>
Signed-off-by: iceseer <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: iceseer <[email protected]>
@iceseer iceseer force-pushed the feature/prospective_parachains_multi_candidates branch from 0ee4703 to 48853ac Compare March 14, 2024 08:09
Signed-off-by: iceseer <[email protected]>
@iceseer iceseer force-pushed the feature/prospective_parachains_multi_candidates branch from 48853ac to fd3e6c6 Compare March 14, 2024 08:37
iceseer added 2 commits April 1, 2024 10:06
Signed-off-by: iceseer <[email protected]>
…_parachains_multi_candidates

Signed-off-by: iceseer <[email protected]>

# Conflicts:
#	core/parachain/pvf/pvf_impl.cpp
#	core/parachain/pvf/pvf_impl.hpp
#	core/runtime/common/runtime_instances_pool.cpp
#	test/core/parachain/pvf_test.cpp
@iceseer iceseer force-pushed the feature/prospective_parachains_multi_candidates branch from 3d2b2e9 to a97547e Compare April 1, 2024 08:07
Signed-off-by: iceseer <[email protected]>
@iceseer iceseer force-pushed the feature/prospective_parachains_multi_candidates branch from a97547e to 7bdfca4 Compare April 1, 2024 08:09
@@ -193,6 +193,8 @@ namespace kagome::network {
*/
virtual std::optional<std::reference_wrapper<PeerState>> getPeerState(
const PeerId &peer_id) = 0;
virtual std::optional<std::reference_wrapper<const PeerState>> getPeerState(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps, non-const method is not used and might be deleted

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нужен для изменения версии и стауса коллатора.

core/parachain/validator/prospective_parachains.hpp Outdated Show resolved Hide resolved
core/parachain/validator/prospective_parachains.hpp Outdated Show resolved Hide resolved
Signed-off-by: iceseer <[email protected]>
@iceseer iceseer merged commit d0de7d0 into master Apr 7, 2024
8 of 10 checks passed
@iceseer iceseer deleted the feature/prospective_parachains_multi_candidates branch April 7, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Respond with multiple backable candidates
4 participants