Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/nix support #2257

Draft
wants to merge 46 commits into
base: master
Choose a base branch
from
Draft

Feature/nix support #2257

wants to merge 46 commits into from

Conversation

Lederstrumpf
Copy link
Contributor

@Lederstrumpf Lederstrumpf commented Nov 1, 2024 •
edited
Loading

Referenced issues

Description of the Change

WIP implemenation of nix shell/flake to build with nix package manager / NixOS.
Tries to strike a balance between Nix conventions and Kagome's current build workflow.
To test, use nix-shell shell.nix or nix develop.

Possible Drawbacks

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? [Yes|No]
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? [Yes|No]
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? [Yes|No]
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. [Yes|No]

@Lederstrumpf Lederstrumpf force-pushed the feature/nix-support branch 2 times, most recently from fe5f1ce to 6640b1e Compare November 4, 2024 13:21
@Lederstrumpf Lederstrumpf mentioned this pull request Nov 4, 2024
Closed
turuslan and others added 14 commits November 11, 2024 10:00
@turuslan
refactor notifications
3584be3 
Signed-off-by: turuslan <[email protected]>
@turuslan
fix moved
168f6aa 
Signed-off-by: turuslan <[email protected]>
@turuslan
fix null
347cc84 
Signed-off-by: turuslan <[email protected]>
@turuslan
fix metric
995b910 
Signed-off-by: turuslan <[email protected]>
@turuslan
parachain if validator
a2513af 
Signed-off-by: turuslan <[email protected]>
@turuslan
sub
75bca79 
Signed-off-by: turuslan <[email protected]>
@turuslan
view
ebbf73c 
Signed-off-by: turuslan <[email protected]>
@turuslan
fix sub
9ddd406 
Signed-off-by: turuslan <[email protected]>
@turuslan
merge master, skip parachain_processor.{hpp,cpp}
976d395 
Signed-off-by: turuslan <[email protected]>
@turuslan
rebase parachain_processor.{hpp,cpp}
8e5821c 
Signed-off-by: turuslan <[email protected]>
@turuslan
fix injector
c130a41 
Signed-off-by: turuslan <[email protected]>
@kamilsa
Merge branch 'master' into refactor/notifications
376f45a
@turuslan
fix thread
15fb5c0 
Signed-off-by: turuslan <[email protected]>
@turuslan
Merge remote-tracking branch 'origin/master' into refactor/notifications
192b29d 
Signed-off-by: turuslan <[email protected]>

# Conflicts:
#	core/parachain/validator/impl/parachain_processor.cpp
#	core/parachain/validator/parachain_processor.hpp
@turuslan
close duplicate connection
d273fac 
Signed-off-by: turuslan <[email protected]>
@turuslan
fix grandpa seen
951df62 
Signed-off-by: turuslan <[email protected]>
@turuslan
fix fwd
bd96c29 
Signed-off-by: turuslan <[email protected]>
@Lederstrumpf
add flake boilerplate
620ea95
@Lederstrumpf
add cmakels
84e6c2f
@Lederstrumpf
move to cmake 3.25.3 release (kagome pin)
b587828
@Lederstrumpf
remove incompatible tooling
c7b5d79
@Lederstrumpf
add rust support & inline relevant init.sh
5b7d155 
except python
@Lederstrumpf
only use laggard nixpkgs for cmake
9f59903 
need more up to date gcc
@Lederstrumpf
add seccomp & ncurses
fc47520
@Lederstrumpf
temp hack: correct curses linking
b7aab3c
@Lederstrumpf
cmake config overrides
5feb4bc
@Lederstrumpf
cmake add erasure_coding_crust override
404d458
@Lederstrumpf
check if initiated via flake
556bbb8
@Lederstrumpf
use standard cargo path :/
d888687
@Lederstrumpf
scripts/build.sh executable by default
9a41ecb
@Lederstrumpf
Revert "use standard cargo path :/"
e2e9354 
This reverts commit bda8f7a.
@Lederstrumpf
segregate out rust vars
2644dbd 
They should be set on Ubuntu, but not Nix: for Nix, .cargo and .rustup
should be within project repo to not pollute system.
@Lederstrumpf
update .gitignore
9fc8530
@Lederstrumpf
add readme explainer
3058757
@Lederstrumpf
fmt
643f94a
@Lederstrumpf
reduce to minimal pkgs
d26ebb5
@Lederstrumpf
update flake description
d273c22
@Lederstrumpf
trim superfluous exports
7d3e45c
@Lederstrumpf
remove shell.nix
430a61d
@Lederstrumpf Lederstrumpf mentioned this pull request Nov 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lederstrumpf @turuslan @kamilsa