Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Chunks are held on rocksdb for 25 hours (#2252)" #2264

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

kamilsa
Copy link
Contributor

@kamilsa kamilsa commented Nov 5, 2024

This reverts commit 8a593bb.

Referenced issues

None

Description of the Change

Commit 8a593bb introduced breaking change as we couldn't launch existing database anymore. Also systematic chunks test started to fail.
As soon as these issues are fixed changes will be merged again

Possible Drawbacks

Little mess with commits

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? Yes
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? Yes
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? Yes
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. Yes

@kamilsa kamilsa marked this pull request as ready for review November 5, 2024 11:02
@kamilsa kamilsa requested review from ErakhtinB and iceseer November 5, 2024 11:03
@kamilsa kamilsa enabled auto-merge (squash) November 5, 2024 11:04
@kamilsa kamilsa merged commit 598bc55 into master Nov 5, 2024
18 of 22 checks passed
@kamilsa kamilsa deleted the fix/revert-chunks branch November 5, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants