Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci/ubuntu migration #2268

Merged
merged 19 commits into from
Nov 12, 2024
Merged

Ci/ubuntu migration #2268

merged 19 commits into from
Nov 12, 2024

Conversation

zerg-su
Copy link
Contributor

@zerg-su zerg-su commented Nov 10, 2024

Referenced issues

Description of the Change

This pull request introduces multiple updates to the GitHub Actions workflows, Docker configurations, and associated build scripts for the Kagome and Zombienet projects. The primary objectives are to improve the build process, enable flexibility in image customization, and standardize the use of Ubuntu (24.04 LTS) for consistency.

Key Changes

  1. GitHub Actions Workflows

    • Updated workflows (.github/workflows/*.yml) to support additional input parameters: builder_latest_tag and zombie_tester_latest_tag.
    • Modified conditional checks to align with these new parameters, enhancing control over rebuilds and custom tag usage.
  2. Dockerfile Updates

    • Renamed minideb.Dockerfile to kagome_runner.Dockerfile and kagome_builder_deb.Dockerfile to kagome_builder.Dockerfile for clarity.
    • Added support for specifying BASE_IMAGE and BASE_IMAGE_TAG to facilitate better compatibility and version tracking.
  3. Makefile Enhancements

    • Introduced new variables (OS_IMAGE, BUILDER_IMAGE_TAG, TESTER_LATEST_TAG) and refactored existing rules for better image tagging and pushing processes.
    • Updated the kagome_dev_docker_build_tidy target to align with new Docker image parameters.
  4. New Install Scripts

    • Added install_packages scripts for both kagome-dev and zombienet to manage dependencies more robustly with retry mechanisms.
  5. Environment Variables

    • Refined environment variable handling, ensuring variables like BUILDER_LATEST_TAG and TESTER_LATEST_TAG are utilized in multiple workflows for consistency.

Possible Drawbacks

Checklist Before Opening a PR

Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item:

  1. Code is formatted: Have you run your code through clang-format to ensure it adheres to the project's coding standards? [Yes|No]
  2. Code is documented: Have you added comments and documentation to your code according to the guidelines in the project's contributing guidelines? [Yes|No]
  3. Self-review: Have you reviewed your own code to ensure it is free of typos, syntax errors, logical errors, and unresolved TODOs or FIXME without linking to an issue? [Yes|No]
  4. Zombienet Tests: Have you ensured that the zombienet tests are passing? Zombienet is a network simulation and testing tool used in this project. It's important to ensure that these tests pass to maintain the stability and reliability of the project. [Yes|No]

@zerg-su zerg-su requested review from xDimon and kamilsa November 10, 2024 21:22
@zerg-su zerg-su enabled auto-merge (squash) November 10, 2024 21:22
.github/workflows/test.yml Outdated Show resolved Hide resolved
@zerg-su zerg-su requested a review from igor-egorov November 12, 2024 08:39
@zerg-su zerg-su merged commit 18889a9 into master Nov 12, 2024
26 of 31 checks passed
@zerg-su zerg-su deleted the ci/ubuntu_migration branch November 12, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants