Made controller render more efficient and added CameraConfig #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added CameraConfig for more configurability
FastestMolasses
commented
Sep 30, 2023
Comment on lines
+88
to
+91
| .insert(CameraConfig { | ||
| height_offset: 0.0, | ||
| radius_scale: 0.75, | ||
| }) |
There was a problem hiding this comment.
This is an insert because we can't add anymore components in the bundle above.
There was a problem hiding this comment.
Wow, did not know you could exhaust that!
There was a problem hiding this comment.
Does this mean we should be using packages or something similar
|
Hi, thank you for the contribution! I will take a look this week - looks good at initial glance. |
qhdwight
reviewed
Oct 24, 2023
| @@ -25,7 +25,16 @@ pub enum MoveMode { | |||
| pub struct LogicalPlayer(pub u8); | |||
|
|
|||
| #[derive(Component)] | |||
| pub struct RenderPlayer(pub u8); | |||
| pub struct RenderPlayer { | |||
| pub id: u8, | |||
There was a problem hiding this comment.
I don't think there is a point to the id anymore then, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some TODO's that I implemented. For this solution, there is no need for a hashmap because we can use Bevy's query system as a hashmap. Now the function is down to O(n).