Integrate optimizers into compiling XXZ code #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ergy by hand. Later something like this will be the documentation of the qibo model
…into compiling_XXZ
|
@MatteoRobbiati I think this is integrated into #52 and #55 ? I closed #34 because it will be impossible to merge that. Please close or move the target branch to those of Andrea, thanks! |
Not yet but we are going to integrate it soon, thus this one can be closed. @andrea-pasquale can you confirm my modifications done in |
|
Yes, to be sure you can rebase this PR to main and I will merge everything here. |
|
You can try to run stuff in #55 using |
Co-authored-by: Andrea Pasquale <[email protected]>
Activating optimizers in refactor/compiling branch
Compiling without results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leave the possibility to use the old GD but also enables to use more optimizers.