You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, backend.calculate_norm calculates one specific norm, which is the Frobenius (aka Hilbert-Schmidt) norm.
So, there are two possibilities here:
Give the method more flexibility to calculate different norms (e.g. numpy.linalg.norm)
Rename the method to specify the only norm that calculates
Another thing is, since the Hilbert-Schmit inner product between two operators is the HS norm squared, we could use backend.calculate_norm to replace backend.calculate_overlap and backend.calculate_overlap_density_matrix entirely.
Moreover, backend.entanglement_entropy is now redundant with qibo.quantum_info.entanglement_entropy.
The content you are editing has changed. Please copy your edits and refresh the page.
@stavros11@scarrazza Now that I am looking at it, there is a bigger problem here: backend.entanglement_entropy is not calculating Entanglement Entropy between two partitions of a quantum system (see qibo.quantum_info.metrics.entanglement_entropy). It is instead calculating "just" the von Neumann entropy of a quantum system (see qibo.quantum_info.metrics.entropy).
Besides that, since the functions in qibo.quantum_info are backend-agnostic, do we even need to keep this method?
@stavros11@scarrazza Now that I am looking at it, there is a bigger problem here: backend.entanglement_entropy is not calculating Entanglement Entropy between two partitions of a quantum system (see qibo.quantum_info.metrics.entanglement_entropy). It is instead calculating "just" the von Neumann entropy of a quantum system (see qibo.quantum_info.metrics.entropy).
Indeed, as far as I remember this function was written only for the EntanglementEntropy callback, which is calling the partial trace in a previous step
Right now,
backend.calculate_norm
calculates one specific norm, which is the Frobenius (aka Hilbert-Schmidt) norm.So, there are two possibilities here:
Another thing is, since the Hilbert-Schmit inner product between two operators is the HS norm squared, we could use
backend.calculate_norm
to replacebackend.calculate_overlap
andbackend.calculate_overlap_density_matrix
entirely.Moreover,
backend.entanglement_entropy
is now redundant withqibo.quantum_info.entanglement_entropy
.Tasks
order
parameter tobackend.calculate_norm
#1043backend.calculate_overlap_density_matrix
innumpy
backend #1044EntanglementEntropy
callback #1045The text was updated successfully, but these errors were encountered: