Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New implementation of EntanglementEntropy callback #1045

Merged
merged 9 commits into from
Oct 30, 2023
Merged

New implementation of EntanglementEntropy callback #1045

merged 9 commits into from
Oct 30, 2023

Conversation

renatomello
Copy link
Contributor

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 16, 2023
@renatomello renatomello added this to the Qibo 0.2.2 milestone Oct 16, 2023
@renatomello renatomello self-assigned this Oct 16, 2023
@renatomello renatomello mentioned this pull request Oct 16, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/qibo/backends/abstract.py 100.00% <ø> (ø)
src/qibo/backends/numpy.py 100.00% <ø> (ø)
src/qibo/backends/tensorflow.py 100.00% <ø> (ø)
src/qibo/callbacks.py 100.00% <100.00%> (ø)
src/qibo/quantum_info/metrics.py 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@renatomello renatomello linked an issue Oct 18, 2023 that may be closed by this pull request
Improvements to backend methods #1023
Closed
stavros11
stavros11 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

src/qibo/callbacks.py Show resolved Hide resolved
tests/test_callbacks.py Show resolved Hide resolved
MatteoRobbiati
MatteoRobbiati approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@MatteoRobbiati MatteoRobbiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@renatomello renatomello merged commit b190a42 into master Oct 30, 2023
26 checks passed
@renatomello renatomello deleted the entanglement_entropy branch October 30, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatteoRobbiati MatteoRobbiati MatteoRobbiati approved these changes

@stavros11 stavros11 stavros11 approved these changes

Assignees

@renatomello renatomello

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
Qibo 0.2.2
Development

Successfully merging this pull request may close these issues.

Improvements to backend methods
3 participants
@renatomello @stavros11 @MatteoRobbiati