-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom decompose
method to gates.U3
and gates.CZ
#1035
Conversation
decompose
method to gates.U3
decompose
method to gates.U3
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments about test and docs, but the feature on its own seems perfectly fine.
decompose
method to gates.U3
decompose
method to gates.U3
and gates.CZ
@renatomello thanks to have applied the suggested corrections! In general, it would be slightly better to pass a pRNG state, rather than using multiple seeds. It's because the properties of pRNG are optimized for sequential extractions, not necessarily for adjacent seeds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @renatomello for adding this. Looks good to me.
Just noting that soon(ish) we will move the transpilers from qibolab to qibo and it would be great if these decompose methods are translated to transpilers to have a unified approach of gate transformations.
Could you open an issue as a reminder for this? |
Checklist: