Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculation of quantum_info.haar_integral exactly #1052

Merged
merged 14 commits into from
Nov 1, 2023
Merged

Calculation of quantum_info.haar_integral exactly #1052

merged 14 commits into from
Nov 1, 2023

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Oct 23, 2023 •
edited
Loading

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 23, 2023
@renatomello renatomello added this to the Qibo 0.2.2 milestone Oct 23, 2023
@renatomello renatomello self-assigned this Oct 23, 2023
@renatomello renatomello mentioned this pull request Oct 23, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 23, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/qibo/models/error_mitigation.py 100.00% <100.00%> (ø)
src/qibo/quantum_info/metrics.py 100.00% <100.00%> (ø)
src/qibo/quantum_info/utils.py 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

MatteoRobbiati
MatteoRobbiati approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@MatteoRobbiati MatteoRobbiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @renatomello. Just one comment follows.

src/qibo/quantum_info/utils.py Outdated Show resolved Hide resolved
src/qibo/quantum_info/utils.py Outdated Show resolved Hide resolved
AlejandroSopena
AlejandroSopena approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@AlejandroSopena AlejandroSopena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Just a small comment:

src/qibo/quantum_info/metrics.py Show resolved Hide resolved
@renatomello renatomello merged commit caa6733 into master Nov 1, 2023
26 checks passed
@renatomello renatomello deleted the haar_integral branch November 1, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatteoRobbiati MatteoRobbiati MatteoRobbiati approved these changes

@AlejandroSopena AlejandroSopena AlejandroSopena approved these changes

@stavros11 stavros11 Awaiting requested review from stavros11

Assignees

@renatomello renatomello

@raghav-tii raghav-tii

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
Qibo 0.2.2
Development

Successfully merging this pull request may close these issues.
4 participants
@renatomello @AlejandroSopena @MatteoRobbiati @raghav-tii