-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move transpiler from Qibolab
to Qibo
#1055
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know! |
With the new modifications Sabre router can also accept measurements gates |
Qibolab
to `Qibo
Qibolab
to Qibo
@renatomello @BrunoLiegiBastonLiegi let me know if you agree with merging this. It is blocking the corresponding PR in qibolab and a few other issues there that need to be moved here. |
for more information, see https://pre-commit.ci
I improved the docstring and other parts of the code. But there are still a few major things that need to be resolved. Mainly, the transpiler needs to be included in the API reference and also the handling of RNG seeds (at least in the router module). If the merger of this PR is urgent, I could approve it and merge it, and leave those things to be fixed in separate PRs. |
It is not urgent as in we will use it immediately (the Sabre part doesn't work anyway) but there are several issues in qibolab (qiboteam/qibolab#606, qiboteam/qibolab#643), including by external people, that I would like to move here and start addressing. Also, updates pushed directly to this PR are practically not reviewed because in the file change everything appears as new. Usually it is better to separate moving (copy-pasting) big chunks of code from new developments for this reason. Regarding the above points, including in the API reference sounds easy to do. For the RNG seeds if it is complicated (as in changing many lines of code) I would rather do in a separate PR or just open an issue and assign to someone. Keep in mind that there are other issues related to this code (some in qiboteam/qibolab#606) that may be more urgent, from a usability point of view. |
Co-authored-by: BrunoLiegiBastonLiegi <[email protected]>
Co-authored-by: BrunoLiegiBastonLiegi <[email protected]>
Co-authored-by: BrunoLiegiBastonLiegi <[email protected]>
Co-authored-by: BrunoLiegiBastonLiegi <[email protected]>
Co-authored-by: BrunoLiegiBastonLiegi <[email protected]>
Checklist: